Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3705 CloudDualStackNodeIPs to GA #45028

Merged
merged 1 commit into from
Feb 10, 2024
Merged

KEP-3705 CloudDualStackNodeIPs to GA #45028

merged 1 commit into from
Feb 10, 2024

Conversation

danwinship
Copy link
Contributor

@danwinship danwinship commented Feb 5, 2024 •
edited
Loading

per kubernetes/enhancements#4415 and kubernetes/kubernetes#123134

I think this is right? First feature gate change since the new feature gate documentation system...

There were no outstanding references to the feature gate in the rest of the documentation. (They were written out when we went to beta.)

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2dd21e8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65c1477900847a00085a03da

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2024
@danwinship danwinship mentioned this pull request Feb 5, 2024
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey February 5, 2024 15:43
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 5, 2024
@dipesh-rawat
Copy link
Member

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Feb 5, 2024
sftim
sftim reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should get a review from SIG Network to confirm this is right.

@sftim
Copy link
Contributor

sftim commented Feb 9, 2024

@danwinship how're you finding the new system? If you've feedback, please mention it in Slack (#sig-docs), or file an issue if it feels serious enough.

@danwinship
Copy link
Contributor Author

It seems a bit more complicated from my end, but mostly just because it's different from how it was before. I assume there's some advantage to SIG Docs for the new system, so...

@danwinship
Copy link
Contributor Author

Should get a review from SIG Network to confirm this is right.

The corresponding code change to the feature gate has already merged: kubernetes/kubernetes@eba4fd8

@sftim
Copy link
Contributor

sftim commented Feb 10, 2024

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d1c6a47e03fe75f389e06ddf9bab6ff10612d8d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 54f3782 into kubernetes:dev-1.30 Feb 10, 2024
6 checks passed
@danwinship danwinship deleted the kep-3705-to-ga branch February 10, 2024 17:59
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
5 participants
@danwinship @dipesh-rawat @sftim @k8s-ci-robot @drewhagen